From 9b524ca5d6bc85378cd53ad3eadf5fb245df5399 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=94=B0=E6=AC=A7?= Date: Sun, 17 Mar 2019 22:58:33 +0800 Subject: [PATCH] update test --- binding/binding_test.go | 35 +++++++++++++++++++++-------------- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/binding/binding_test.go b/binding/binding_test.go index 00146e1d..cb06f404 100644 --- a/binding/binding_test.go +++ b/binding/binding_test.go @@ -550,43 +550,50 @@ func createFormPostRequestForMapFail(t *testing.T) *http.Request { return req } -func createFormFilesMultipartRequest() *http.Request { +func createFormFilesMultipartRequest(t *testing.T) *http.Request { boundary := "--testboundary" body := new(bytes.Buffer) mw := multipart.NewWriter(body) defer mw.Close() - mw.SetBoundary(boundary) - mw.WriteField("foo", "bar") - mw.WriteField("bar", "foo") + assert.NoError(t, mw.SetBoundary(boundary)) + assert.NoError(t, mw.WriteField("foo", "bar")) + assert.NoError(t, mw.WriteField("bar", "foo")) - f, _ := os.Open("form.go") + f, err := os.Open("form.go") + assert.NoError(t, err) defer f.Close() - fw, _ := mw.CreateFormFile("file", "form.go") + fw, err1 := mw.CreateFormFile("file", "form.go") + assert.NoError(t, err1) + io.Copy(fw, f) - req, _ := http.NewRequest("POST", "/?foo=getfoo&bar=getbar", body) + req, err2 := http.NewRequest("POST", "/?foo=getfoo&bar=getbar", body) + assert.NoError(t, err2) req.Header.Set("Content-Type", MIMEMultipartPOSTForm+"; boundary="+boundary) return req } -func createFormFilesMultipartRequestFail() *http.Request { +func createFormFilesMultipartRequestFail(t *testing.T) *http.Request { boundary := "--testboundary" body := new(bytes.Buffer) mw := multipart.NewWriter(body) defer mw.Close() - mw.SetBoundary(boundary) - mw.WriteField("foo", "bar") - mw.WriteField("bar", "foo") + assert.NoError(t, mw.SetBoundary(boundary)) + assert.NoError(t, mw.WriteField("foo", "bar")) + assert.NoError(t, mw.WriteField("bar", "foo")) - f, _ := os.Open("form.go") + f, err := os.Open("form.go") + assert.NoError(t, err) defer f.Close() - fw, _ := mw.CreateFormFile("file_foo", "form_foo.go") + fw, err1 := mw.CreateFormFile("file_foo", "form_foo.go") + assert.NoError(t, err1) io.Copy(fw, f) - req, _ := http.NewRequest("POST", "/?foo=getfoo&bar=getbar", body) + req, err2 := http.NewRequest("POST", "/?foo=getfoo&bar=getbar", body) + assert.NoError(t, err2) req.Header.Set("Content-Type", MIMEMultipartPOSTForm+"; boundary="+boundary) return req