From 93f9e4860dc2ba098031b1852ec845ee77bacacc Mon Sep 17 00:00:00 2001
From: wuhuizuo <wuhuizuo@gmail.com>
Date: Wed, 25 Dec 2019 20:57:25 +0800
Subject: [PATCH] [FIX] Validate()

---
 binding/binding_test.go      |  3 ++-
 binding/default_validator.go | 24 +++++++++---------------
 2 files changed, 11 insertions(+), 16 deletions(-)

diff --git a/binding/binding_test.go b/binding/binding_test.go
index a3af5875..00f0cc19 100644
--- a/binding/binding_test.go
+++ b/binding/binding_test.go
@@ -187,7 +187,8 @@ func TestBindingJSONSlice(t *testing.T) {
 	}()
 
 	testBodyBindingSlice(t, JSON, "json", "/", "/", `[]`, ``)
-	testBodyBindingSlice(t, JSON, "json", "/", "/", `[{}]`, `{}`)
+	testBodyBindingSlice(t, JSON, "json", "/", "/", `[{"foo": "123"}]`, `[{}]`)
+	testBodyBindingSlice(t, JSON, "json", "/", "/", `[{"foo": "123"}]`, `[{"foo": ""}]`)
 	testBodyBindingSlice(t, JSON, "json", "/", "/", `[{"foo": "123"}]`, `[{"foo": 123}]`)
 	testBodyBindingSlice(t, JSON, "json", "/", "/", `[{"foo": "123"}]`, `[{"bar": 123}]`)
 	testBodyBindingSlice(t, JSON, "json", "/", "/", `[{"foo": "123"}]`, `[{"foo": "123456789012345678901234567890123"}]`)
diff --git a/binding/default_validator.go b/binding/default_validator.go
index cc0f9169..25dcb554 100644
--- a/binding/default_validator.go
+++ b/binding/default_validator.go
@@ -5,14 +5,13 @@
 package binding
 
 import (
-	"reflect"
 	"fmt"
-	"sync"
-	"strings"
 	"log"
+	"reflect"
+	"strings"
+	"sync"
 
 	"github.com/go-playground/validator/v10"
-	// "github.com/ahmetb/go-linq"
 )
 
 type defaultValidator struct {
@@ -20,7 +19,7 @@ type defaultValidator struct {
 	validate *validator.Validate
 }
 
-type sliceValidateError []error 
+type sliceValidateError []error
 
 func (err sliceValidateError) Error() string {
 	var errMsgs []string
@@ -28,7 +27,7 @@ func (err sliceValidateError) Error() string {
 		if e == nil {
 			continue
 		}
-		errMsgs = append(errMsgs, fmt.Sprintf("[%d]: %s", i, err.Error()))
+		errMsgs = append(errMsgs, fmt.Sprintf("[%d]: %s", i, e.Error()))
 	}
 	return strings.Join(errMsgs, "\n")
 }
@@ -37,29 +36,24 @@ var _ ValidatorImp = &defaultValidator{}
 
 // ValidateStruct receives any kind of type, but only performed struct or pointer to struct type.
 func (v *defaultValidator) Validate(obj interface{}) error {
-	log.Println("called")
 	if obj == nil {
 		return nil
 	}
 
 	value := reflect.ValueOf(obj)
 	valueType := value.Kind()
-	log.Printf("valueType: %v, %#v\n", valueType, valueType)
 	if valueType == reflect.Ptr {
-		value = value.Elem()
-		valueType = value.Kind()
+		return v.Validate(value.Elem().Interface())
 	}
 
-	switch valueType {	
+	switch valueType {
 	case reflect.Struct:
-		log.Printf("goto validateStruct: %v, %#v\n", obj, obj)
 		return v.validateStruct(obj)
 	case reflect.Slice, reflect.Array:
 		count := value.Len()
 		validateRet := make(sliceValidateError, 0)
 		for i := 0; i < count; i++ {
-			log.Println("called inside slice")
-			if err := v.Validate(value.Index(i)); err != nil {
+			if err := v.Validate(value.Index(i).Interface()); err != nil {
 				validateRet = append(validateRet, err)
 			}
 		}
@@ -67,7 +61,7 @@ func (v *defaultValidator) Validate(obj interface{}) error {
 		if len(validateRet) == 0 {
 			return nil
 		}
-		return validateRet		
+		return validateRet
 	default:
 		return nil
 	}