Merge ce03fdda7d9a13288eb16721619d4a97f7983a1b into 8763f33c65f7df8be5b9fe7504ab7fcf20abb41d

context.go

@@ -1051,9 +1051,14 @@ func (c *Context) Render(code int, r render.Render) {
 	}
 
 	if err := r.Render(c.Writer); err != nil {
-		// Pushing error to c.Errors
-		_ = c.Error(err)
-		c.Abort()
+		// if err is net error, pushing error to c.Errors
+		netOpErr := &net.OpError{}
+		if ok := errors.As(err, &netOpErr); ok {
+			_ = c.Error(err)
+			c.Abort()
+		} else {
+			panic(err)
+		}
 	}
 }
 

context_test.go

@@ -36,7 +36,15 @@ import (
 
 var _ context.Context = (*Context)(nil)
 
-var errTestRender = errors.New("TestRender")
+var errTestRender = errors.New("TestPanicRender")
+
+var errNetOpErr = &net.OpError{
+	Op:     "testneterr",
+	Net:    "",
+	Source: nil,
+	Addr:   nil,
+	Err:    nil,
+}
 
 // Unit tests TODO
 // func (c *Context) File(filepath string) {
@@ -891,21 +899,41 @@ func TestContextBodyAllowedForStatus(t *testing.T) {
 	assert.True(t, true, bodyAllowedForStatus(http.StatusInternalServerError))
 }
 
-type TestRender struct{}
+type TestPanicRender struct{}
 
-func (*TestRender) Render(http.ResponseWriter) error {
+func (*TestPanicRender) Render(http.ResponseWriter) error {
 	return errTestRender
 }
 
-func (*TestRender) WriteContentType(http.ResponseWriter) {}
+func (*TestPanicRender) WriteContentType(http.ResponseWriter) {}
+
+func TestContextRenderPanicIfErr(t *testing.T) {
+	defer func() {
+		r := recover()
+		assert.Equal(t, fmt.Sprint(errTestRender), fmt.Sprint(r))
+	}()
 
-func TestContextRenderIfErr(t *testing.T) {
 	w := httptest.NewRecorder()
 	c, _ := CreateTestContext(w)
 
-	c.Render(http.StatusOK, &TestRender{})
+	c.Render(http.StatusOK, &TestPanicRender{})
+}
 
-	assert.Equal(t, errorMsgs{&Error{Err: errTestRender, Type: 1}}, c.Errors)
+type TestNetErrorRender struct{}
+
+func (*TestNetErrorRender) Render(http.ResponseWriter) error {
+	return errNetOpErr
+}
+
+func (*TestNetErrorRender) WriteContentType(http.ResponseWriter) {}
+
+func TestContextRenderIfNetErr(t *testing.T) {
+	w := httptest.NewRecorder()
+	c, _ := CreateTestContext(w)
+
+	c.Render(http.StatusOK, &TestNetErrorRender{})
+
+	assert.Equal(t, errorMsgs{&Error{Err: errNetOpErr, Type: 1}}, c.Errors)
 }
 
 // Tests that the response is serialized as JSON