From 8dba11b0f23422ac3601788f2cc11b2fb266a1f9 Mon Sep 17 00:00:00 2001
From: yonbiaoxiao <yonbiaoxiao@tencent.com>
Date: Thu, 17 Sep 2020 19:44:29 +0800
Subject: [PATCH] use IndexByte replace Split to improve performance

---
 utils.go      | 5 ++++-
 utils_test.go | 6 ++++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/utils.go b/utils.go
index fab3aee3..c32f0eeb 100644
--- a/utils.go
+++ b/utils.go
@@ -103,7 +103,10 @@ func parseAccept(acceptHeader string) []string {
 	parts := strings.Split(acceptHeader, ",")
 	out := make([]string, 0, len(parts))
 	for _, part := range parts {
-		if part = strings.TrimSpace(strings.Split(part, ";")[0]); part != "" {
+		if i := strings.IndexByte(part, ';'); i > 0 {
+			part = part[:i]
+		}
+		if part = strings.TrimSpace(part); part != "" {
 			out = append(out, part)
 		}
 	}
diff --git a/utils_test.go b/utils_test.go
index 9b57c57b..cc486c35 100644
--- a/utils_test.go
+++ b/utils_test.go
@@ -18,6 +18,12 @@ func init() {
 	SetMode(TestMode)
 }
 
+func BenchmarkParseAccept(b *testing.B) {
+	for i := 0; i < b.N; i++ {
+		parseAccept("text/html , application/xhtml+xml,application/xml;q=0.9,  */* ;q=0.8")
+	}
+}
+
 type testStruct struct {
 	T *testing.T
 }