From 808ea1897b8a4899f4a4ecc941d2041edbd0381c Mon Sep 17 00:00:00 2001
From: mehrdadbn9 <mehrdadbiukian@gmail.com>
Date: Thu, 5 Feb 2026 21:55:28 +0330
Subject: [PATCH] Fix concurrent-safe route registration

Add sync.RWMutex to protect concurrent access to the trees slice
in Engine struct. This fixes a data race between addRoute() and
Routes() functions where one goroutine appends to trees while
another reads from it.

Changes:
- Add mu sync.RWMutex field to Engine struct
- Protect addRoute() with Lock/Unlock
- Protect Routes() with RLock/RUnlock

Fixes #4457
---
 gin.go | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gin.go b/gin.go
index 2e033bf3..472c9ec8 100644
--- a/gin.go
+++ b/gin.go
@@ -96,6 +96,10 @@ type Engine struct {
 	// (used for routing HTTP requests) happens only once, even if called multiple times concurrently.
 	routeTreesUpdated sync.Once
 
+
+	// mu protects concurrent access to trees
+	mu sync.RWMutex
+
 	// RedirectTrailingSlash enables automatic redirection if the current route can't be matched but a
 	// handler for the path with (without) the trailing slash exists.
 	// For example if /foo/ is requested but a route only exists for /foo, the
@@ -368,6 +372,9 @@ func (engine *Engine) addRoute(method, path string, handlers HandlersChain) {
 
 	debugPrintRoute(method, path, handlers)
 
+	engine.mu.Lock()
+	defer engine.mu.Unlock()
+
 	root := engine.trees.get(method)
 	if root == nil {
 		root = new(node)
@@ -388,6 +395,8 @@ func (engine *Engine) addRoute(method, path string, handlers HandlersChain) {
 // Routes returns a slice of registered routes, including some useful information, such as:
 // the http method, path, and the handler name.
 func (engine *Engine) Routes() (routes RoutesInfo) {
+	engine.mu.RLock()
+	defer engine.mu.RUnlock()
 	for _, tree := range engine.trees {
 		routes = iterate("", tree.method, routes, tree.root)
 	}