From 77d70e5858278193abfab732164b0c1415d8d4ba Mon Sep 17 00:00:00 2001 From: Name <1911860538@qq.com> Date: Mon, 9 Jun 2025 21:05:34 +0800 Subject: [PATCH] refactor(internal/bytesconv): replace rand usage with crypto/rand and rand.Int63 (#4259) Co-authored-by: huangzw --- internal/bytesconv/bytesconv_test.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/internal/bytesconv/bytesconv_test.go b/internal/bytesconv/bytesconv_test.go index 497069ce..ff26e35e 100644 --- a/internal/bytesconv/bytesconv_test.go +++ b/internal/bytesconv/bytesconv_test.go @@ -6,6 +6,7 @@ package bytesconv import ( "bytes" + cRand "crypto/rand" "math/rand" "strings" "testing" @@ -30,7 +31,10 @@ func rawStrToBytes(s string) []byte { func TestBytesToString(t *testing.T) { data := make([]byte, 1024) for i := 0; i < 100; i++ { - rand.Read(data) + _, err := cRand.Read(data) + if err != nil { + t.Fatal(err) + } if rawBytesToStr(data) != BytesToString(data) { t.Fatal("don't match") } @@ -44,7 +48,7 @@ const ( letterIdxMax = 63 / letterIdxBits // # of letter indices fitting in 63 bits ) -var src = rand.NewSource(time.Now().UnixNano()) +var src = rand.New(rand.NewSource(time.Now().UnixNano())) func RandStringBytesMaskImprSrcSB(n int) string { sb := strings.Builder{}