blackteay/gin
3
0
Fork 0
mirror of https://github.com/gin-gonic/gin.git synced 2026-06-06 20:18:19 +08:00
Code Issues Projects Releases Wiki Activity

quick fix to skip binding body without content type

Browse Source
This commit is contained in:
takanuva15 2026-03-30 17:29:21 -04:00
parent e00c839047
commit 71e83183db
2 changed files with 17 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
binding/all.go
View File

@ -36,11 +36,16 @@ func (allBinding) BindMany(req *http.Request, uriParams map[string][]string, obj
// from context.Bind (for body/post-form/anything else)
contentType := req.Header.Get("Content-Type")
// trim contentType parameters, e.g. "application/json; charset=utf-8" -> "application/json"
contentTypeLastIdx := strings.IndexAny(contentType, " ;")
contentTypeLastIdx := strings.IndexAny(contentType, " ;") // trim "application/json; charset=utf-8" -> "application/json"
if contentTypeLastIdx != -1 {
contentType = contentType[:contentTypeLastIdx]
}
// if no Content-Type, assume request has no body. This avoids binding query params again in binding.Default
if contentType == "" {
return validate(obj)
}
b := Default(req.Method, contentType)
// final validation done by whatever binding is selected here
return b.Bind(req, obj)

18
context.go
View File

@ -808,10 +808,11 @@ func (c *Context) BindUri(obj any) error {
// It will abort the request with HTTP 400 if any error occurs.
//
// Note:
// - Caller must tag struct fields appropriately for the desired binding (eg `header:"xxx"` vs `uri:"xxx"`)
// - Caller must ensure no duplication between field names (else use separate binding engines instead)
// - Caller must provide Content-Type header to select the correct body binding (eg "application/json" for JSON binding)
// - Binding validation tags are verified after all request parts have been bound
// - Caller must tag struct fields appropriately for the desired binding (eg `header:"xxx"` vs `uri:"xxx"`)
// - Caller must ensure no duplication between field names (else use separate binding engines instead)
// - Caller must provide Content-Type header to select the correct body binding (eg "application/json" for JSON binding).
// A request without Content-Type will result in no body binding
// - Binding validation tags are verified after all request parts have been bound
func (c *Context) BindAll(obj any) error {
err := c.ShouldBindAll(obj)
if err != nil {
@ -945,10 +946,11 @@ func (c *Context) ShouldBindUri(obj any) error {
// Like c.Bind() but this method does not set the response status code to 400 or abort if input is not valid.
//
// Note:
// - Caller must tag struct fields appropriately for the desired binding (eg `header:"xxx"` vs `uri:"xxx"`)
// - Caller must ensure no duplication between field names (else use separate binding engines instead)
// - Caller must provide Content-Type header to select the correct body binding (eg "application/json" for JSON binding)
// - Binding validation tags are verified after all request parts have been bound
// - Caller must tag struct fields appropriately for the desired binding (eg `header:"xxx"` vs `uri:"xxx"`)
// - Caller must ensure no duplication between field names (else use separate binding engines instead)
// - Caller must provide Content-Type header to select the correct body binding (eg "application/json" for JSON binding).
// A request without Content-Type will result in no body binding
// - Binding validation tags are verified after all request parts have been bound
func (c *Context) ShouldBindAll(obj any) error {
uriParams := make(map[string][]string, len(c.Params))
for _, v := range c.Params {