mirror of
https://github.com/gin-gonic/gin.git
synced 2025-10-17 22:32:26 +08:00
optimize code and reduce code cyclomatic complexity
This commit is contained in:
parent
328d0b8076
commit
59171e3425
@ -22,10 +22,8 @@ func (formBinding) Bind(req *http.Request, obj interface{}) error {
|
|||||||
if err := req.ParseForm(); err != nil {
|
if err := req.ParseForm(); err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
if err := req.ParseMultipartForm(defaultMemory); err != nil {
|
if err := req.ParseMultipartForm(defaultMemory); err != nil && err != http.ErrNotMultipart {
|
||||||
if err != http.ErrNotMultipart {
|
return err
|
||||||
return err
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
if err := mapForm(obj, req.Form); err != nil {
|
if err := mapForm(obj, req.Form); err != nil {
|
||||||
return err
|
return err
|
||||||
|
52
debug.go
52
debug.go
@ -24,36 +24,38 @@ func IsDebugging() bool {
|
|||||||
var DebugPrintRouteFunc func(httpMethod, absolutePath, handlerName string, nuHandlers int)
|
var DebugPrintRouteFunc func(httpMethod, absolutePath, handlerName string, nuHandlers int)
|
||||||
|
|
||||||
func debugPrintRoute(httpMethod, absolutePath string, handlers HandlersChain) {
|
func debugPrintRoute(httpMethod, absolutePath string, handlers HandlersChain) {
|
||||||
if IsDebugging() {
|
if !IsDebugging() {
|
||||||
nuHandlers := len(handlers)
|
return
|
||||||
handlerName := nameOfFunction(handlers.Last())
|
}
|
||||||
if DebugPrintRouteFunc == nil {
|
nuHandlers := len(handlers)
|
||||||
debugPrint("%-6s %-25s --> %s (%d handlers)\n", httpMethod, absolutePath, handlerName, nuHandlers)
|
handlerName := nameOfFunction(handlers.Last())
|
||||||
} else {
|
if DebugPrintRouteFunc == nil {
|
||||||
DebugPrintRouteFunc(httpMethod, absolutePath, handlerName, nuHandlers)
|
debugPrint("%-6s %-25s --> %s (%d handlers)\n", httpMethod, absolutePath, handlerName, nuHandlers)
|
||||||
}
|
} else {
|
||||||
|
DebugPrintRouteFunc(httpMethod, absolutePath, handlerName, nuHandlers)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func debugPrintLoadTemplate(tmpl *template.Template) {
|
func debugPrintLoadTemplate(tmpl *template.Template) {
|
||||||
if IsDebugging() {
|
if !IsDebugging() {
|
||||||
var buf strings.Builder
|
return
|
||||||
for _, tmpl := range tmpl.Templates() {
|
|
||||||
buf.WriteString("\t- ")
|
|
||||||
buf.WriteString(tmpl.Name())
|
|
||||||
buf.WriteString("\n")
|
|
||||||
}
|
|
||||||
debugPrint("Loaded HTML Templates (%d): \n%s\n", len(tmpl.Templates()), buf.String())
|
|
||||||
}
|
}
|
||||||
|
var buf strings.Builder
|
||||||
|
for _, tmpl := range tmpl.Templates() {
|
||||||
|
buf.WriteString("\t- ")
|
||||||
|
buf.WriteString(tmpl.Name())
|
||||||
|
buf.WriteString("\n")
|
||||||
|
}
|
||||||
|
debugPrint("Loaded HTML Templates (%d): \n%s\n", len(tmpl.Templates()), buf.String())
|
||||||
}
|
}
|
||||||
|
|
||||||
func debugPrint(format string, values ...interface{}) {
|
func debugPrint(format string, values ...interface{}) {
|
||||||
if IsDebugging() {
|
if !IsDebugging() {
|
||||||
if !strings.HasSuffix(format, "\n") {
|
return
|
||||||
format += "\n"
|
|
||||||
}
|
|
||||||
fmt.Fprintf(DefaultWriter, "[GIN-debug] "+format, values...)
|
|
||||||
}
|
}
|
||||||
|
if !strings.HasSuffix(format, "\n") {
|
||||||
|
format += "\n"
|
||||||
|
}
|
||||||
|
fmt.Fprintf(DefaultWriter, "[GIN-debug] "+format, values...)
|
||||||
}
|
}
|
||||||
|
|
||||||
func getMinVer(v string) (uint64, error) {
|
func getMinVer(v string) (uint64, error) {
|
||||||
@ -95,9 +97,7 @@ at initialization. ie. before any route is registered or the router is listening
|
|||||||
}
|
}
|
||||||
|
|
||||||
func debugPrintError(err error) {
|
func debugPrintError(err error) {
|
||||||
if err != nil {
|
if err != nil && IsDebugging() {
|
||||||
if IsDebugging() {
|
fmt.Fprintf(DefaultErrorWriter, "[GIN-debug] [ERROR] %v\n", err)
|
||||||
fmt.Fprintf(DefaultErrorWriter, "[GIN-debug] [ERROR] %v\n", err)
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
Loading…
x
Reference in New Issue
Block a user