From 48c3482b5d647a088a9fa1de7eec14f6c6cfa971 Mon Sep 17 00:00:00 2001 From: Dustin Date: Fri, 1 Jun 2018 19:33:17 -0500 Subject: [PATCH] don't log requests --- recovery.go | 4 +--- recovery_test.go | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/recovery.go b/recovery.go index 61c5bd53..1c4b2ae6 100644 --- a/recovery.go +++ b/recovery.go @@ -11,7 +11,6 @@ import ( "io/ioutil" "log" "net/http" - "net/http/httputil" "runtime" "time" ) @@ -39,8 +38,7 @@ func RecoveryWithWriter(out io.Writer) HandlerFunc { if err := recover(); err != nil { if logger != nil { stack := stack(3) - httprequest, _ := httputil.DumpRequest(c.Request, false) - logger.Printf("[Recovery] %s panic recovered:\n%s\n%s\n%s%s", timeFormat(time.Now()), string(httprequest), err, stack, reset) + logger.Printf("[Recovery] %s panic recovered:\n%s\n%s%s", timeFormat(time.Now()), err, stack, reset) } c.AbortWithStatus(http.StatusInternalServerError) } diff --git a/recovery_test.go b/recovery_test.go index 53f4a071..71edac6d 100644 --- a/recovery_test.go +++ b/recovery_test.go @@ -24,7 +24,7 @@ func TestPanicInHandler(t *testing.T) { w := performRequest(router, "GET", "/recovery") // TEST assert.Equal(t, http.StatusInternalServerError, w.Code) - assert.Contains(t, buffer.String(), "GET /recovery") + assert.Contains(t, buffer.String(), "panic recovered") assert.Contains(t, buffer.String(), "Oupps, Houston, we have a problem") assert.Contains(t, buffer.String(), "TestPanicInHandler") }