Merge branch 'master' into mode-tc-2

This commit is contained in:
Bo-Yi Wu 2019-09-24 21:32:53 +08:00 committed by GitHub
commit 37d28c7a22
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 24 additions and 9 deletions

View File

@ -10,7 +10,6 @@ matrix:
env: GO111MODULE=on env: GO111MODULE=on
- go: 1.13.x - go: 1.13.x
- go: master - go: master
env: GO111MODULE=on
git: git:
depth: 10 depth: 10

View File

@ -1678,11 +1678,19 @@ func main() {
} }
g.Go(func() error { g.Go(func() error {
return server01.ListenAndServe() err := server01.ListenAndServe()
if err != nil && err != http.ErrServerClosed {
log.Fatal(err)
}
return err
}) })
g.Go(func() error { g.Go(func() error {
return server02.ListenAndServe() err := server02.ListenAndServe()
if err != nil && err != http.ErrServerClosed {
log.Fatal(err)
}
return err
}) })
if err := g.Wait(); err != nil { if err := g.Wait(); err != nil {

View File

@ -393,8 +393,7 @@ func (c *Context) QueryArray(key string) []string {
func (c *Context) getQueryCache() { func (c *Context) getQueryCache() {
if c.queryCache == nil { if c.queryCache == nil {
c.queryCache = make(url.Values) c.queryCache = c.Request.URL.Query()
c.queryCache, _ = url.ParseQuery(c.Request.URL.RawQuery)
} }
} }

View File

@ -347,7 +347,17 @@ func TestRenderRedirect(t *testing.T) {
} }
w = httptest.NewRecorder() w = httptest.NewRecorder()
assert.Panics(t, func() { assert.NoError(t, data2.Render(w)) }) assert.PanicsWithValue(t, "Cannot redirect with status code 200", func() { data2.Render(w) })
data3 := Redirect{
Code: http.StatusCreated,
Request: req,
Location: "/new/location",
}
w = httptest.NewRecorder()
err = data3.Render(w)
assert.NoError(t, err)
// only improve coverage // only improve coverage
data2.WriteContentType(w) data2.WriteContentType(w)

View File

@ -65,11 +65,10 @@ func min(a, b int) int {
func countParams(path string) uint8 { func countParams(path string) uint8 {
var n uint var n uint
for i := 0; i < len(path); i++ { for i := 0; i < len(path); i++ {
if path[i] != ':' && path[i] != '*' { if path[i] == ':' || path[i] == '*' {
continue
}
n++ n++
} }
}
if n >= 255 { if n >= 255 {
return 255 return 255
} }