blackteay/gf
1
0
Fork 0
mirror of https://github.com/gogf/gf.git synced 2025-04-05 03:05:05 +08:00
Code Issues Projects Releases Wiki Activity

fix(net/ghttp): MiddlewareHandlerResponse writes additional information after custom response wrote (#4109)

Browse Source
This commit is contained in:
Wlynxg 2025-01-14 09:28:19 +08:00 committed by GitHub
parent 3f24b4da2e
commit e0f734851e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/ghttp/ghttp_middleware_handler_response.go
View File

@ -37,7 +37,7 @@ func MiddlewareHandlerResponse(r *Request) {
r.Middleware.Next()
// There's custom buffer content, it then exits current handler.
if r.Response.BufferLength() > 0 {
if r.Response.BufferLength() > 0 || r.Response.Writer.BytesWritten() > 0 {
return
}

26
net/ghttp/ghttp_z_unit_issue_test.go
View File

@ -9,6 +9,7 @@ package ghttp_test
import (
"context"
"fmt"
"net/http"
"testing"
"time"
@ -630,3 +631,28 @@ func Test_Issue4047(t *testing.T) {
t.Assert(s.Logger(), nil)
})
}
// https://github.com/gogf/gf/issues/4108
func Test_Issue4108(t *testing.T) {
s := g.Server(guid.S())
s.Group("/", func(group *ghttp.RouterGroup) {
group.Middleware(ghttp.MiddlewareHandlerResponse)
group.GET("/", func(r *ghttp.Request) {
r.Response.Writer.Write([]byte("hello"))
})
})
s.SetDumpRouterMap(false)
s.Start()
defer s.Shutdown()
time.Sleep(100 * time.Millisecond)
gtest.C(t, func(t *gtest.T) {
client := g.Client()
client.SetPrefix(fmt.Sprintf("http://127.0.0.1:%d", s.GetListenedPort()))
rsp, err := client.Get(ctx, "/")
t.AssertNil(err)
t.Assert(rsp.StatusCode, http.StatusOK)
t.Assert(rsp.ReadAllString(), "hello")
})
}