blackteay/gf
1
0
Fork 0
mirror of https://github.com/gogf/gf.git synced 2025-04-05 11:18:50 +08:00
Code Issues Projects Releases Wiki Activity

net/ghttp: fix Content-Type for jsonp response from application/json to application/javascript (#3651)

Browse Source
This commit is contained in:
swift 2024-06-24 21:37:49 +08:00 committed by GitHub
parent 7d464d4de2
commit dba6c08548
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
net/ghttp/ghttp.go
View File

@ -154,6 +154,7 @@ const (
contentTypeXml = "text/xml"
contentTypeHtml = "text/html"
contentTypeJson = "application/json"
contentTypeJavascript = "application/javascript"
swaggerUIPackedPath = "/goframe/swaggerui"
responseHeaderTraceID = "Trace-ID"
responseHeaderContentLength = "Content-Length"

2
net/ghttp/ghttp_response_write.go
View File

@ -131,7 +131,7 @@ func (r *Response) WriteJsonExit(content interface{}) {
//
// Note that there should be a "callback" parameter in the request for JSONP format.
func (r *Response) WriteJsonP(content interface{}) {
r.Header().Set("Content-Type", contentTypeJson)
r.Header().Set("Content-Type", contentTypeJavascript)
// If given string/[]byte, response it directly to client.
switch content.(type) {
case string, []byte:

2
net/ghttp/ghttp_z_unit_feature_response_test.go
View File

@ -301,6 +301,8 @@ func Test_Response_Write(t *testing.T) {
t.Assert(client.GetContent(ctx, "/Writefln", "name=john"), "john\n")
t.Assert(client.GetContent(ctx, "/WriteJson"), "{\"name\":\"john\"}")
t.Assert(client.GetContent(ctx, "/WriteJsonP"), "{\"name\":\"john\"}")
resp, _ := client.DoRequest(ctx, http.MethodGet, "/WriteJsonP", "{\"name\":\"john\"}", nil)
t.Assert(resp.Header.Get("Content-Type"), "application/javascript")
t.Assert(client.GetContent(ctx, "/WriteJsonPWithStruct"), "{\"name\":\"john\"}")
t.Assert(client.GetContent(ctx, "/WriteJsonPWithStruct", "callback=callback"),
"callback({\"name\":\"john\"})")