fix(util/gvalid): lots of memory consumed when required validation on big binary field (#4097)

util/gvalid/gvalid_validator_check_value.go

@@ -287,26 +287,40 @@ func (v *Validator) doCheckValueRecursively(ctx context.Context, in doCheckValue
 		}
 
 	case reflect.Slice, reflect.Array:
-		var array []interface{}
+		loop := false
-		if gjson.Valid(in.Value) {
+		switch in.Type.Elem().Kind() {
-			array = gconv.Interfaces(gconv.Bytes(in.Value))
+		// []struct []map
-		} else {
+		case reflect.Struct, reflect.Map:
-			array = gconv.Interfaces(in.Value)
+			loop = true
+		case reflect.Ptr:
+			loop = true
 		}
-		if len(array) == 0 {
+		// When it is a base type array,
-			return
+		// there is no need for recursive loop validation,
-		}
+		// otherwise it will cause memory leakage
-		for _, item := range array {
+		// https://github.com/gogf/gf/issues/4092
-			v.doCheckValueRecursively(ctx, doCheckValueRecursivelyInput{
+		if loop {
-				Value:               item,
+			var array []interface{}
-				Type:                in.Type.Elem(),
+			if gjson.Valid(in.Value) {
-				Kind:                in.Type.Elem().Kind(),
+				array = gconv.Interfaces(gconv.Bytes(in.Value))
-				ErrorMaps:           in.ErrorMaps,
+			} else {
-				ResultSequenceRules: in.ResultSequenceRules,
+				array = gconv.Interfaces(in.Value)
-			})
+			}
-			// Bail feature.
+			if len(array) == 0 {
-			if v.bail && len(in.ErrorMaps) > 0 {
+				return
-				break
+			}
+			for _, item := range array {
+				v.doCheckValueRecursively(ctx, doCheckValueRecursivelyInput{
+					Value:               item,
+					Type:                in.Type.Elem(),
+					Kind:                in.Type.Elem().Kind(),
+					ErrorMaps:           in.ErrorMaps,
+					ResultSequenceRules: in.ResultSequenceRules,
+				})
+				// Bail feature.
+				if v.bail && len(in.ErrorMaps) > 0 {
+					break
+				}
 			}
 		}
 	}

util/gvalid/gvalid_z_unit_issue_test.go

@@ -9,6 +9,7 @@ package gvalid_test
 import (
 	"context"
 	"fmt"
+	"runtime"
 	"testing"
 	"time"
 
@@ -114,3 +115,37 @@ func Test_Issue3636(t *testing.T) {
 		)
 	})
 }
+
+// https://github.com/gogf/gf/issues/4092
+func Test_Issue4092(t *testing.T) {
+	type Model struct {
+		Raw  []byte `v:"required"`
+		Test []byte `v:"foreach|in:1,2,3"`
+	}
+	gtest.C(t, func(t *gtest.T) {
+		const kb = 1024
+		const mb = 1024 * kb
+		raw := make([]byte, 50*mb)
+		in := &Model{
+			Raw:  raw,
+			Test: []byte{40, 5, 6},
+		}
+		err := g.Validator().
+			Data(in).
+			Run(context.Background())
+		t.Assert(err, "The Test value `6` is not in acceptable range: 1,2,3")
+		allocMb := getMemAlloc()
+		t.AssertLE(allocMb, 110)
+	})
+}
+
+func getMemAlloc() uint64 {
+	byteToMb := func(b uint64) uint64 {
+		return b / 1024 / 1024
+	}
+	var m runtime.MemStats
+	runtime.ReadMemStats(&m)
+	// For info on each, see: https://golang.org/pkg/runtime/#MemStats
+	alloc := byteToMb(m.Alloc)
+	return alloc
+}