blackteay/gf
1
0
Fork 0
mirror of https://github.com/gogf/gf.git synced 2025-04-05 03:05:05 +08:00
Code Issues Projects Releases Wiki Activity

fix(net/ghttp): BufferWriter.Flush writes additional information after custom response wrote (#4116)

Browse Source
This commit is contained in:
Wlynxg 2025-01-22 09:28:06 +08:00 committed by GitHub
parent e0f734851e
commit 99f0fb14a1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
net/ghttp/ghttp_z_unit_issue_test.go
View File

@ -656,3 +656,25 @@ func Test_Issue4108(t *testing.T) {
t.Assert(rsp.ReadAllString(), "hello")
})
}
// https://github.com/gogf/gf/issues/4115
func Test_Issue4115(t *testing.T) {
s := g.Server(guid.S())
s.Use(func(r *ghttp.Request) {
r.Response.Writer.Write([]byte("hello"))
})
s.SetDumpRouterMap(false)
s.Start()
defer s.Shutdown()
time.Sleep(100 * time.Millisecond)
gtest.C(t, func(t *gtest.T) {
client := g.Client()
client.SetPrefix(fmt.Sprintf("http://127.0.0.1:%d", s.GetListenedPort()))
rsp, err := client.Get(ctx, "/")
t.AssertNil(err)
t.Assert(rsp.StatusCode, http.StatusOK)
t.Assert(rsp.ReadAllString(), "hello")
})
}

2
net/ghttp/internal/response/response_buffer_writer.go
View File

@ -82,7 +82,7 @@ func (w *BufferWriter) Flush() {
w.Writer.WriteHeader(w.Status)
}
// Default status text output.
if w.Status != http.StatusOK && w.buffer.Len() == 0 {
if w.Status != http.StatusOK && w.buffer.Len() == 0 && w.Writer.BytesWritten() == 0 {
w.buffer.WriteString(http.StatusText(w.Status))
}
if w.buffer.Len() > 0 {