blackteay/gf
1
0
Fork 0
mirror of https://github.com/gogf/gf.git synced 2025-04-05 11:18:50 +08:00
Code Issues Projects Releases Wiki Activity

fix(database/gdb): fix #3649 when constructing query param, gdb.Row value not directly write to Buffer (#3718)

Browse Source
This commit is contained in:
CyJaySong 2024-08-14 21:16:17 +08:00 committed by GitHub
parent a6c361dcf7
commit 6e5ce98d23
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
contrib/drivers/mysql/mysql_z_unit_issue_test.go
View File

@ -1199,3 +1199,20 @@ func Test_Issue3238(t *testing.T) {
}
})
}
// https://github.com/gogf/gf/issues/3649
func Test_Issue3649(t *testing.T) {
table := createInitTable()
defer dropTable(table)
gtest.C(t, func(t *gtest.T) {
sql, err := gdb.CatchSQL(context.Background(), func(ctx context.Context) (err error) {
user := db.Model(table).Ctx(ctx)
_, err = user.Where("create_time = ?", gdb.Raw("now()")).WhereLT("create_time", gdb.Raw("now()")).Count()
return
})
t.AssertNil(err)
sqlStr := fmt.Sprintf("SELECT COUNT(1) FROM `%s` WHERE (create_time = now()) AND (`create_time` < now())", table)
t.Assert(sql[0], sqlStr)
})
}

6
database/gdb/gdb_func.go
View File

@ -777,11 +777,7 @@ func formatWhereKeyValue(in formatWhereKeyValueInput) (newArgs []interface{}) {
} else {
in.Buffer.WriteString(quotedKey)
}
if s, ok := in.Value.(Raw); ok {
in.Buffer.WriteString(gconv.String(s))
} else {
in.Args = append(in.Args, in.Value)
}
in.Args = append(in.Args, in.Value)
}
}
return in.Args