blackteay/gf
1
0
Fork 0
mirror of https://github.com/gogf/gf.git synced 2025-04-05 11:18:50 +08:00
Code Issues Projects Releases Wiki Activity

fix: gutil.IsSlice judgment logic error (#2910)

Browse Source
This commit is contained in:
the harder the luckier 2023-09-04 20:09:55 +08:00 committed by GitHub
parent e60262fec9
commit 3da5e5e865
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
internal/utils/utils_is.go
View File

@ -57,6 +57,7 @@ func IsSlice(value interface{}) bool {
) )
for reflectKind == reflect.Ptr { for reflectKind == reflect.Ptr {
reflectValue = reflectValue.Elem() reflectValue = reflectValue.Elem()
reflectKind = reflectValue.Kind()
} }
switch reflectKind { switch reflectKind {
case reflect.Slice, reflect.Array: case reflect.Slice, reflect.Array:

5
internal/utils/utils_z_unit_is_test.go
View File

@ -9,8 +9,10 @@ package utils_test
import ( import (
"testing" "testing"
"github.com/gogf/gf/v2/container/gvar"
"github.com/gogf/gf/v2/frame/g" "github.com/gogf/gf/v2/frame/g"
"github.com/gogf/gf/v2/internal/utils" "github.com/gogf/gf/v2/internal/utils"
"github.com/gogf/gf/v2/os/gtime"
"github.com/gogf/gf/v2/test/gtest" "github.com/gogf/gf/v2/test/gtest"
) )
@ -124,6 +126,9 @@ func TestVar_IsSlice(t *testing.T) {
t.Assert(utils.IsSlice(int8(1)), false) t.Assert(utils.IsSlice(int8(1)), false)
t.Assert(utils.IsSlice(uint8(1)), false) t.Assert(utils.IsSlice(uint8(1)), false)
}) })
gtest.C(t, func(t *gtest.T) {
t.Assert(utils.IsSlice(gvar.New(gtime.Now()).IsSlice()), false)
})
} }
func TestVar_IsMap(t *testing.T) { func TestVar_IsMap(t *testing.T) {