#18: fix to use latest #17 changes

ffmpeg/_view.py

@@ -6,15 +6,28 @@ import os
 import tempfile
 
 from ffmpeg.nodes import (
+    FilterNode,
     InputNode,
     OutputNode,
-    FilterNode,
-    operator,
+    Stream,
+    stream_operator,
 )
 
 
-@operator()
-def view(*downstream_nodes, **kwargs):
+def _get_node_color(node):
+    if isinstance(node, InputNode):
+        color = '#99cc00'
+    elif isinstance(node, OutputNode):
+        color = '#99ccff'
+    elif isinstance(node, FilterNode):
+        color = '#ffcc00'
+    else:
+        color = None
+    return color
+
+
+@stream_operator()
+def view(*streams, **kwargs):
     try:
         import graphviz
     except ImportError:
@@ -22,11 +35,17 @@ def view(*downstream_nodes, **kwargs):
             'graphviz`)')
 
     filename = kwargs.pop('filename', None)
-    show_labels = kwargs.pop('show_labels', False)
+    show_labels = kwargs.pop('show_labels', True)
     if filename is None:
         filename = tempfile.mktemp()
 
-    sorted_nodes, outgoing_edge_maps = topo_sort(downstream_nodes)
+    nodes = []
+    for stream in streams:
+        if not isinstance(stream, Stream):
+            raise TypeError('Expected Stream; got {}'.format(type(stream)))
+        nodes.append(stream.node)
+
+    sorted_nodes, outgoing_edge_maps = topo_sort(nodes)
     graph = graphviz.Digraph()
     graph.attr(rankdir='LR')
     if len(kwargs.keys()) != 0:
@@ -36,20 +55,17 @@ def view(*downstream_nodes, **kwargs):
         name = node.name
         if '_kwargs' in dir(node) and 'filename' in node._kwargs:
             name = os.path.basename(node._kwargs['filename'])
-        if isinstance(node, InputNode):
-            color = '#99cc00'
-        elif isinstance(node, OutputNode):
-            color = '#99ccff'
-        elif isinstance(node, FilterNode):
-            color = '#ffcc00'
-        else:
-            color = None
+        color = _get_node_color(node)
+
         graph.node(str(hash(node)), name, shape='box', style='filled', fillcolor=color)
         outgoing_edge_map = outgoing_edge_maps.get(node, {})
+
         for edge in get_outgoing_edges(node, outgoing_edge_map):
             kwargs = {}
-            if show_labels:
-                kwargs['label'] = '{} -> {}'.format(edge.upstream_label, edge.downstream_label)
+            if show_labels and (edge.upstream_label is not None or edge.downstream_label is not None):
+                upstream_label = edge.upstream_label if edge.upstream_label is not None else ''
+                downstream_label = edge.downstream_label if edge.downstream_label is not None else ''
+                kwargs['label'] = '{}     {}'.format(upstream_label, downstream_label)
             upstream_node_id = str(hash(edge.upstream_node))
             downstream_node_id = str(hash(edge.downstream_node))
             graph.edge(upstream_node_id, downstream_node_id, **kwargs)